Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wall following #397

Merged
merged 8 commits into from
May 3, 2023
Merged

Improve wall following #397

merged 8 commits into from
May 3, 2023

Conversation

knmcguire
Copy link
Member

For this PR ive introduced the wall following demo: #390

There were comments made by @krichardsson there that I've addressed + more documentation and clarification

@knmcguire knmcguire linked an issue May 2, 2023 that may be closed by this pull request
Fixes to the wall following demo #391
Closed
@knmcguire knmcguire added this to the next release milestone May 2, 2023
krichardsson
krichardsson approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@krichardsson krichardsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer and easier to read!

I found a few magic numbers (comments in the code) if you want to fix them, but nothing big.

Good job!

examples/multiranger/multiranger_wall_following.py Show resolved Hide resolved
examples/multiranger/wall_following/wall_following.py Outdated Show resolved Hide resolved
examples/multiranger/wall_following/wall_following.py Show resolved Hide resolved
examples/multiranger/wall_following/wall_following.py Show resolved Hide resolved
examples/multiranger/multiranger_wall_following.py Outdated Show resolved Hide resolved
@knmcguire
Copy link
Member Author

knmcguire commented May 3, 2023 •
edited

Thanks for reviewing! And good you found those extra magic numbers... wonder if there is some kind of CI check for this we could implement.

I've made some changes per your suggestion and will merge it now.

@knmcguire knmcguire merged commit ab0898a into master May 3, 2023
1 check passed
@knmcguire knmcguire deleted the improve_wall_following branch May 3, 2023 09:12
This was referenced May 3, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichardsson krichardsson krichardsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.23
Development

Successfully merging this pull request may close these issues.

Fixes to the wall following demo
2 participants
@knmcguire @krichardsson