Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to TypeScript #314

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Switch to TypeScript #314

merged 1 commit into from
Sep 29, 2021

Conversation

pmeinhardt
Copy link
Contributor

No description provided.

@pmeinhardt pmeinhardt force-pushed the typescript branch 11 times, most recently from c84d388 to a544237 Compare September 5, 2021 20:43
@pmeinhardt pmeinhardt marked this pull request as ready for review September 5, 2021 22:27
@pmeinhardt
Copy link
Contributor Author

I converted our code to TypeScript and made a lot of improvements along the way. A large portion of @tessi's work on the formatter made it in here. I think this will be hard to review. I would suggest checking out this branch and then test-riding a local build for some time. ✌️

@tessi & @klappradla 💚

@klappradla
Copy link
Member

First suspicious encounter while test-riding 🚲

The Jira adapter returns the same result for branch, command and message: always the message.

See this quick onehanded demo with one foot out the door 🍿

ticktick

@pmeinhardt
Copy link
Contributor Author

pmeinhardt commented Sep 9, 2021

First suspicious encounter while test-riding 🚲

The Jira adapter returns the same result for branch, command and message: always the message.

Can you check the values for the commit, branch and command templates on the settings page?

@pmeinhardt pmeinhardt mentioned this pull request Sep 16, 2021
4 tasks
@klappradla
Copy link
Member

Can you check the values for the commit, branch and command templates on the settings page?

I have the following config:

  • autoformat: off

  • message:

    [{id}] {title}
    
    [{id}]({url})
    
  • branch: (default I think)

    {type | slugify}/{id | slugify}-{title | slugify}
    
  • command (default I think)

    git checkout -b {branch | shellquote} && git commit --allow-empty -m {commit | shellquote}
    

Update 🚨

What I did not realize in #314 (comment) as I had to put it down so fast: the message button is the only one that actually works! The other buttons don't populate the clipboard.

Co-authored-by: Max Mulatz <max@bitcrowd.net>
Copy link
Member

@klappradla klappradla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the 2nd beta now - running smooth since a week 🧘

Let's ⛵

@pmeinhardt pmeinhardt merged commit 30f9b62 into main Sep 29, 2021
@pmeinhardt pmeinhardt deleted the typescript branch September 29, 2021 18:44
@pmeinhardt pmeinhardt added this to the 5.0 milestone Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants