Add between

[ibarrae]

Between was added by myself on #111 but it was reverted on #123 due to the fact that new between clause was not working with non-val values as @parsonsmatt mentioned here.

I changed that and also included some tests to cover that case.

Please, let me know if there's another missing case so I can also address it 😃

[parsonsmatt]

I think we should support composite keys instead of throwing an error. Otherwise this looks fantastic, thanks! 😄

[ibarrae]

Hey, @parsonsmatt I just pushed some changes but it maintains BetweenError because I figured out while doing some tests that when you mix scalar and composite values it also fails on different databases (using between and >= <= accordingly ) and would lead to runtime errors, so I think it's better to throw an error if this scenario occurs.. Summing up, it works when all values for between are scalar or composite only, but it cannot be scalar and composite. Let me know what you think of this.

mysql> select * from point where ((x, y) >= (1) and (x,y) <= (3,4));
ERROR 1241 (21000): Operand should contain 2 column(s)

postgres> select 1 from table where (1, 2) >= 1 and (1, 2) <= (2,3);
select 1 from table where (1, 2) between 1 and (3, 4); 
ERROR:  operator does not exist: record >= integer

[ibarrae]

I updated unsafeSqlBinOp, would you mind taking a look again @parsonsmatt

[ibarrae]

Hey @parsonsmatt I think I got this correctly this time, could you take a look when possible, please and also, CI seems to be failing due to a time out, could you restart it if possible too?

[parsonsmatt]

Approved, pending the @since modification and a CHANGELOG entry please 😄

[ibarrae]

@parsonsmatt Done! I updated the version number and updated the changelog entry, thanks a lot for your help in this 😄

[parsonsmatt]

Thank you! You've written a new feature, discovered a bug, and fixed that bug all in one go 😄