refactor: return error on pipe from Wait method after completion of pipe
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahadzaryab1
changed the title
WaitError method for returning error after completion of pipeWait method after completion of pipe
mahadzaryab1
changed the title
Wait method after completion of pipeWait method after completion of pipe
ccoVeille
reviewed
Aug 24, 2024
bitfield
requested changes
Aug 26, 2024
bitfield
requested changes
Aug 27, 2024
script_test.go
Outdated
| @@ -1850,6 +1850,22 @@ func TestReadReturnsErrorGivenReadErrorOnPipe(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestWaitForErrorOnPipe(t *testing.T) { | |||
There was a problem hiding this comment.
If you try gotestdox here, as discussed on the other PR, you'll see why this test name doesn't quite fit with the others:
✔ Error returns error set by previous pipe stage (0.00s)
...
✔ Wait reads pipe source to completion (0.00s)
...
✔ Wait for error on pipe (0.00s)
✔ Wait for no error on pipe (0.00s)
See what I mean? It's not a sentence describing the effect that Wait has. (This is why I find gotestdox so useful as a thinking tool: it forces me to describe the behaviour of the thing I'm implementing.)
There was a problem hiding this comment.
Thanks for the great suggestion @bitfield! changed the test names to conform to your suggestion. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
Waitmethod to return the error present on the pipe after completion. This PR closes #123.