Add v2 endpoints #89
Merged
Add v2 endpoints #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 16, 2019 09:23
f3rno
suggested changes
Oct 21, 2019
lib/models/order.rb
Outdated
| # placeholder | ||
| # placeholder | ||
| # placeholder | ||
| :notify => 24, |
There was a problem hiding this comment.
This doesn't seem correct, it is at index 23 in the docs & bfx-api-node-models, can you confirm?
There was a problem hiding this comment.
according to the docs:
[
# ID, 1
# GID, 2
# CID, 3
# SYMBOL, 4
# MTS_CREATE, 5
# MTS_UPDATE, 6
# AMOUNT, 7
# AMOUNT_ORIG, 8
# TYPE, 9
# TYPE_PREV, 10
# MTS_TIF, 11
# _PLACEHOLDER, 12
# FLAGS, 13
# ORDER_STATUS, 14
# _PLACEHOLDER, 15
# _PLACEHOLDER, 16
# PRICE, 17
# PRICE_AVG, 18
# PRICE_TRAILING, 19
# PRICE_AUX_LIMIT, 20
# _PLACEHOLDER, 21
# _PLACEHOLDER, 22
# _PLACEHOLDER, 23
# _PLACEHOLDER, 24
# HIDDEN, 25
# PLACED_ID, 26
# _PLACEHOLDER, 27
# _PLACEHOLDER, 28
# ROUTING, 29
# _PLACEHOLDER, 30
# _PLACEHOLDER, 31
# META 32
# ],
There was a problem hiding this comment.
so by that, hidden (notify) is 24 (I forgot to zero index)
There was a problem hiding this comment.
Ignore this - turns out the docs is missing the NOTIFY field in the v2 rest response which confused met. Fixed now
lib/rest/v2/funding.rb
Outdated
| end | ||
|
|
||
| ### | ||
| # Close a funding loan/credit |
lib/rest/v2/orders.rb
Outdated
| # @return [Array] Raw notification | ||
| ### | ||
| def update_order (changes) | ||
| id = changes[:id] || changes['id'] |
lib/rest/v2/positions.rb
Outdated
| elsif position.kind_of?(Hash) | ||
| id = position[:id] || position['id'] | ||
| else | ||
| raise Exception, 'tried to cancel position with invalid ID' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds all of the new v2 rest endpoints and adds the capability to specify leverage when creating an order.
Breaking changes:
-None
New features:
Fixes:
Fix fields for Order model, originally it was attempting to get some fields (like hidden) using the wrong index.
PR status:
Documentation updated- no documentation for rest yet