bug: app crashes while clicking on webdav accounts in the menu

[meiser79]

Hi,

I'd like to report a app crash while clicking on webdav accounts in the menu. It's "WebDAV-Zugänge" under "Wekzeuge".

The logcat shows:

04-01 16:43:22.020 E/AndroidRuntime(25023): FATAL EXCEPTION: DefaultDispatcher-worker-1
04-01 16:43:22.020 E/AndroidRuntime(25023): Process: at.bitfire.davdroid, PID: 25023
04-01 16:43:22.020 E/AndroidRuntime(25023): javax.crypto.AEADBadTagException
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.keystore2.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:611)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at javax.crypto.Cipher.doFinal(Cipher.java:2114)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at com.google.crypto.tink.integration.android.AndroidKeystoreAesGcm.decryptInternal(AndroidKeystoreAesGcm.java:28)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at com.google.crypto.tink.integration.android.AndroidKeystoreAesGcm.decrypt(AndroidKeystoreAesGcm.java:6)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at com.google.crypto.tink.KeysetHandle.read(KeysetHandle.java:37)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at com.google.crypto.tink.integration.android.AndroidKeysetManager$Builder.readMasterkeyDecryptAndParseKeyset(AndroidKeysetManager.java:26)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at com.google.crypto.tink.integration.android.AndroidKeysetManager$Builder.build(AndroidKeysetManager.java:45)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.CredentialsStore.<init>(CredentialsStore.kt:257)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider$credentialsStore$2.invoke(DavDocumentsProvider.kt:1)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider$credentialsStore$2.invoke(DavDocumentsProvider.kt:2)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:21)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider.getCredentialsStore(DavDocumentsProvider.kt:3)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider.access$getCredentialsStore(DavDocumentsProvider.kt:1)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider$actor$2.invoke(DavDocumentsProvider.kt:1)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider$actor$2.invoke(DavDocumentsProvider.kt:2)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:21)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider.getActor(DavDocumentsProvider.kt:3)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider.access$getActor(DavDocumentsProvider.kt:1)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at at.bitfire.davdroid.webdav.DavDocumentsProvider$queryChildDocuments$running$1$1.invokeSuspend(DavDocumentsProvider.kt:12)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:111)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:4)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:3)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:98)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@a5fb102, Dispatchers.IO]
04-01 16:43:22.020 E/AndroidRuntime(25023): Caused by: android.security.KeyStoreException: Signature/MAC verification failed (internal Keystore code: -30 message: In KeystoreOperation::finish
04-01 16:43:22.020 E/AndroidRuntime(25023): 
04-01 16:43:22.020 E/AndroidRuntime(25023): Caused by:
04-01 16:43:22.020 E/AndroidRuntime(25023):     0: In finish: KeyMint::finish failed.
04-01 16:43:22.020 E/AndroidRuntime(25023):     1: Error::Km(ErrorCode(-30))) (public error code: 10 internal Keystore code: -30)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.KeyStore2.getKeyStoreException(KeyStore2.java:369)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.KeyStoreOperation.handleExceptions(KeyStoreOperation.java:78)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.KeyStoreOperation.finish(KeyStoreOperation.java:128)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.keystore2.KeyStoreCryptoOperationChunkedStreamer$MainDataStream.finish(KeyStoreCryptoOperationChunkedStreamer.java:228)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.keystore2.KeyStoreCryptoOperationChunkedStreamer.doFinal(KeyStoreCryptoOperationChunkedStreamer.java:181)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.keystore2.AndroidKeyStoreAuthenticatedAESCipherSpi$BufferAllOutputUntilDoFinalStreamer.doFinal(AndroidKeyStoreAuthenticatedAESCipherSpi.java:396)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	at android.security.keystore2.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:603)
04-01 16:43:22.020 E/AndroidRuntime(25023): 	... 23 more
04-01 16:43:22.026 I/DropBoxManagerService(1763): add tag=data_app_crash isTagEnabled=true flags=0x2
04-01 16:43:22.027 I/Process (25023): Sending signal. PID: 25023 SIG: 9
04-01 16:43:22.032 W/BroadcastQueue(1763): Background execution not allowed: receiving Intent { act=android.intent.action.DROPBOX_ENTRY_ADDED flg=0x10 (has extras) } to com.google.android.gms/.chimera.GmsIntentOperationService$PersistentTrustedReceiver
04-01 16:43:22.033 W/BroadcastQueue(1763): Background execution not allowed: receiving Intent { act=android.intent.action.DROPBOX_ENTRY_ADDED flg=0x10 (has extras) } to com.google.android.gms/.stats.service.DropBoxEntryAddedReceiver
04-01 16:43:22.052 I/ActivityManager(1763): Process at.bitfire.davdroid (pid 25023) has died: fg  BTOP
04-01 16:43:22.052 I/libprocessgroup(1763): Successfully killed process cgroup uid 10421 pid 25023 in 0ms
04-01 16:43:22.053 I/Zygote  (885): Process 25023 exited due to signal 9 (Killed)
04-01 16:43:22.053 I/libprocessgroup(1763): Successfully killed process cgroup uid 10421 pid 25023 in 0ms
04-01 16:43:22.055 D/DefaultSelectionTracker(15904): Ignoring onDataSetChange. No active selection.

May I ask you to have a look?
Thanks in advance,
meiser

[rfc2822]

Seems that the private key of the encrypted file that stores WebDAV usernames/passwords was tampered.

Please provide more information, including steps to reproduce. Did you modify DAVx5 files or maybe restore it from a backup? Which Android variant / version do you use?

[meiser79]

I'm running crDroid 9.15 (based on LineageOS 20, Android 13) on my Xiaomi Poco F3.

Sadly, I do not know how to reproduce the issue. It suddenly appeared while I just wanted to check the webdav settings. I cannot access my webdav mount via the files app (com.android.documentsui), too.

Is it possible to reset the webdav settings without resetting the whole app including the caldav/carddav settings?

[rfc2822]

Unfortunately not, the code currently relies on an unmodified storage for credentials. You can reset the app data + remove the DAVx5 accounts and add them + WebDAV again.

[meiser79]

Ok, after resetting the app data and configuring everything again, it's up and running again.