-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support COMMENT for tasks #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rfc2822
reviewed
May 14, 2024
rfc2822
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I now have removed the trim()
because the other properties are not trimmed at this position, too. There's some removeBlackStrings()
logic in AndroidEvent
; maybe it can be refactored at some time. However we should treat all properties the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support task comments.
Short description
comment
field toTask
.Task
to read theCOMMENT
property into thecomment
fieldTask
to generate theCOMMENT
property from thecomment
fieldDmfsTask
: GeneratesCOMMENT
data row (probably with languagenull
) fromTask.comment
fieldDmfsTask
: ProcessesCOMMENT
data row and fillsTask.comment
field from itChecklist
I have added documentation to complex functions and functions that can be used by other modules.