Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted window resizing #352

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Adjusted window resizing #352

merged 1 commit into from
Jun 17, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

The keyboard covers the bottom bar when open. Probably caused because resizing is not enabled in the activity.

Keyboard open Keyboard closed
image image

Short description

  • Added android:windowSoftInputMode="adjustResize" to the manifest for AddCalendarActivity.
  • Disabled setDecorFitsSystemWindows for AddCalendarActivity.
  • Added imePadding to the contents of AddCalendarActivity.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Adjusted window resizing
0bdab1b 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Jun 17, 2024
@ArnyminerZ ArnyminerZ self-assigned this Jun 17, 2024
@ArnyminerZ ArnyminerZ linked an issue Jun 17, 2024 that may be closed by this pull request
Keyboard covers bottom bar #351
Closed
@ArnyminerZ ArnyminerZ requested a review from sunkup June 17, 2024 11:59
@ArnyminerZ ArnyminerZ marked this pull request as ready for review June 17, 2024 11:59
@sunkup sunkup modified the milestone: 2.2.4 Jun 17, 2024
sunkup
sunkup approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@sunkup sunkup merged commit e386557 into dev Jun 17, 2024
7 checks passed
@sunkup sunkup deleted the 351-keyboard-covers-bottom-bar branch June 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard covers bottom bar
2 participants
@ArnyminerZ @sunkup