Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal actions to change colours #495

Closed
sphlabs opened this issue Feb 14, 2019 · 3 comments
Closed

Add internal actions to change colours #495

sphlabs opened this issue Feb 14, 2019 · 3 comments
Labels
area/internal Related to an internal action or function of Companion. Enhancement New feature or request Good first issue Good for newcomers Nice to have Would be nice, but not high priority.

Comments

@sphlabs
Copy link

sphlabs commented Feb 14, 2019

Describe the feature
Add internal actions, that can be assigned to button presses, to change the text/background colour of any button.

Is this platform dependent (windows, mac, ..)?
No.

If documentation is required to implement, do you know where to find it?
N/A

Usecases
One might build a sequence of buttons that need firing in a particular order. As one button is triggered, its colour is changed, and the colour of the next button to press is changed.

A set of buttons that only want to be fired once, but in a random order. As each one is trigged it can change its appearance to indicate it has been fired.

@krocheck
Copy link
Member

krocheck commented Feb 18, 2019

So I have some thoughts/comments on this.

I had a case a couple weeks backs for Watchout where I would have liked to see as tally the last button I pressed and then tally in a different color buttons which are valid presses from that state. It was a shotbox.

You could implement these as internal under [release] actions, but since they're actions then there's no automated clear ability, as is present within the feedback framework. So, as-is you'd need to do a 'Clear color' action under the subsequent button to reset the color of the previous button ... and then how do you handle someone pressing the button out of sequence due to error or needing to jump a cue. Feedback can get way out of whack.

Now, setting a button to internal change its color to show its been fired is much clearer and easy to do. But, how do we handle the need to reset (beyond relaunching the software).

I'm not quashing this ... just playing devil's advocate based on the structures in place.

@willosof
Copy link
Member

Hmm. Without having the capacity to go into the concepts of programming with it, it's definitely easy to implement.

@willosof willosof added Enhancement New feature or request Good first issue Good for newcomers area/internal Related to an internal action or function of Companion. Nice to have Would be nice, but not high priority. labels Feb 18, 2019
@willosof
Copy link
Member

willosof commented Mar 3, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal Related to an internal action or function of Companion. Enhancement New feature or request Good first issue Good for newcomers Nice to have Would be nice, but not high priority.
Projects
None yet
Development

No branches or pull requests

3 participants