Fix issue when parsing style #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx I totally missed it from last PR (testcases didn't catch it) I will merge it soon. |
|
The travis failings seems to be unrelated to the PR |
|
@san650 It's not blocked on travis failure, but something slightly more subtle. I can't actually verify it works across browser so I didn't merge yet. I will re-run again... |
|
released as v1.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bitinn,
Found an issue when parsing the style of an element that has more attributes than style properties, egg:
The cause is the nested
forin https://github.com/bitinn/vdom-parser/blob/master/index.js#L157 using the same variable as the outerfor.This is a possible solution,
Cheers!