This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
support non-chunked pubsub endpoints #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| state = read_body; | ||
| } | ||
| break; |
|
juicy |
| req = evhttp_request_new(NULL, NULL); | ||
| req->kind = EVHTTP_RESPONSE; | ||
| // 1 is the constant ALL_DATA_READ in http-internal.h | ||
| if ((evhttp_parse_firstline(req, EVBUFFER_INPUT(bev)) == 1) |
There was a problem hiding this comment.
i think for correctness this should have separate states to parse the first line then parse the headers
…d autodetect whether or not the response is chunked; add convenience methods to perform a non-blocking HTTP request stream (stream_request.c)
|
ready for review |
jehiah
added a commit
that referenced
this pull request
Aug 18, 2011
support non-chunked pubsub endpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to
pubsubclientin order to support both chunked and non-chunked source pubsub endpoints via autodetection.introduce
stream_request.c(this could move intolibsimplehttp) to perform non-blocking HTTP stream requests