Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter button not recognised in search input on iOS #117

Closed
Stuart4 opened this issue Jan 25, 2024 · 4 comments · Fixed by #235
Closed

Enter button not recognised in search input on iOS #117

Stuart4 opened this issue Jan 25, 2024 · 4 comments · Fixed by #235
Labels
bug Something isn't working

Comments

@Stuart4
Copy link

Stuart4 commented Jan 25, 2024

Have you checked the roadmap on the website, and existing issues, before opening a dupllcate issue?
Yes

Describe the bug
Unable to trigger search query.

To Reproduce

  1. using a mobile iOS device
  2. load the web ui
  3. enter a search term in the search box
  4. press enter

Expected behavior
Torrent content should populate as on other devices

General (please complete the following information):

  • Bitmagnet version: v0.4.1
  • OS and version: iPadOS 17.2
  • Browser and version (if issue is with WebUI): Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.2 Safari/605.1.15

Additional context
Same behavior on iPhone.

@Stuart4 Stuart4 added the bug Something isn't working label Jan 25, 2024
@mgdigital mgdigital changed the title Broken Search Enter button not recognised in search input on iOS Jan 27, 2024
@mgdigital
Copy link
Collaborator

Hi, it seems that pressing enter in the search box doesn't trigger the usual keyup event on iOS.

In general, the app has not been designed for or tested on mobile at all (because most people will be using it on desktop alongside their desktop BitTorrent client). Better mobile support is a medium-term goal but not the highest priority right now so I'll leave this open for the time being.

@josteink
Copy link
Contributor

josteink commented Mar 16, 2024

While its obvious Bitmagnet is not yet designed/optimized for mobile use, this particular bug means it's not actually usable at all.

Like literally cannot use it. Because you will never be able to ... search for anything.

This could probably be fixed very easily by also handling the blur-event on the input-field, and not just responding to enter.

It might be as easy duplicating these lines:

(keyup.enter)="
search.setQueryString(queryString.value ?? '');
search.firstPage();
search.loadResult()

And adding this:

            (blur)="
              search.setQueryString(queryString.value ?? '');
              search.firstPage();
              search.loadResult()

@josteink
Copy link
Contributor

Another workaround could be to make the refresh button always consider the input-field before issuing the network request.

These should be fairly small changes in code which would make a very big impact (not usable at all on iphones => actually usable).

josteink added a commit to josteink/bitmagnet that referenced this issue Mar 28, 2024
keyup.enter event does not seem to trigger for Safari on iOS.
Trigger update-code on blur-event too to workaround.

This fixes bitmagnet-io#117.
@josteink
Copy link
Contributor

josteink commented Mar 28, 2024

I've provided a very simplistic workaround for this in the following PR: #235

Tested locally on iPhone and works correctly as far as I see. Review, pretty please?

Also: Happy easter!

mgdigital pushed a commit that referenced this issue Mar 30, 2024
* Torrent search: Fix for Safari on iOS.

keyup.enter event does not seem to trigger for Safari on iOS.
Trigger update-code on blur-event too to workaround.

This fixes #117.

* Update embedded npm content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants