-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter button not recognised in search input on iOS #117
Comments
Hi, it seems that pressing enter in the search box doesn't trigger the usual keyup event on iOS. In general, the app has not been designed for or tested on mobile at all (because most people will be using it on desktop alongside their desktop BitTorrent client). Better mobile support is a medium-term goal but not the highest priority right now so I'll leave this open for the time being. |
While its obvious Bitmagnet is not yet designed/optimized for mobile use, this particular bug means it's not actually usable at all. Like literally cannot use it. Because you will never be able to ... search for anything. This could probably be fixed very easily by also handling the blur-event on the input-field, and not just responding to enter. It might be as easy duplicating these lines: bitmagnet/webui/src/app/search/torrent-content/torrent-content.component.html Lines 99 to 102 in e9e19a5
And adding this:
|
Another workaround could be to make the refresh button always consider the input-field before issuing the network request. These should be fairly small changes in code which would make a very big impact (not usable at all on iphones => actually usable). |
keyup.enter event does not seem to trigger for Safari on iOS. Trigger update-code on blur-event too to workaround. This fixes bitmagnet-io#117.
I've provided a very simplistic workaround for this in the following PR: #235 Tested locally on iPhone and works correctly as far as I see. Review, pretty please? Also: Happy easter! |
* Torrent search: Fix for Safari on iOS. keyup.enter event does not seem to trigger for Safari on iOS. Trigger update-code on blur-event too to workaround. This fixes #117. * Update embedded npm content
Have you checked the roadmap on the website, and existing issues, before opening a dupllcate issue?
Yes
Describe the bug
Unable to trigger search query.
To Reproduce
Expected behavior
Torrent content should populate as on other devices
General (please complete the following information):
Additional context
Same behavior on iPhone.
The text was updated successfully, but these errors were encountered: