Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BITMAKER-3465 Stats module: Apply pagination to jobs per day in estela #204

Merged
merged 6 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions estela-api/api/serializers/notification.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ def to_representation(self, instance):
if is_superuser and not user_in_project:
ret["notification"]["user"]["username"] = "Bitmaker Cloud Admin"
else:
ret["notification"]["user"][
"username"
] = user.username
ret["notification"]["user"]["username"] = user.username
return ret


Expand Down
70 changes: 53 additions & 17 deletions estela-api/api/serializers/stats.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from datetime import timedelta
from rest_framework import serializers

from api.serializers.spider import SpiderSerializer
from api.serializers.job import SpiderJobSerializer
from core.models import SpiderJob


Expand Down Expand Up @@ -55,30 +57,64 @@ class StatsSerializer(serializers.Serializer):
jobs = JobsStatsSerializer(required=False)
pages = PagesStatsSerializer()
items_count = serializers.IntegerField(default=0)
runtime = serializers.FloatField(default=0.0)
runtime = serializers.DurationField(default=timedelta(hours=0, minutes=0))
status_codes = StatusCodesStatsSerializer()
success_rate = serializers.FloatField(default=0.0)
success_rate = serializers.FloatField(default=0.0, required=False)
logs = LogsStatsSerializer()
coverage = CoverageStatsSerializer()
coverage = CoverageStatsSerializer(required=False)


class SpidersJobsStatsSerializer(SpiderJobSerializer):
stats = StatsSerializer()

class JobsMetadataSerializer(serializers.ModelSerializer):
class Meta:
model = SpiderJob
fields = ("jid", "spider", "job_status")


class GetJobsStatsSerializer(serializers.Serializer):
jid = serializers.IntegerField(default=0)
spider = serializers.IntegerField(default=0)
stats = StatsSerializer(required=False)


class GlobalStatsSerializer(serializers.Serializer):
fields = (
"jid",
"spider",
"created",
"name",
"lifespan",
"total_response_bytes",
"item_count",
"request_count",
"args",
"env_vars",
"tags",
"job_status",
"cronjob",
"data_expiry_days",
"data_status",
"stats",
)


class ProjectStatsSerializer(serializers.Serializer):
date = serializers.DateField()
stats = StatsSerializer()
jobs_metadata = JobsMetadataSerializer(many=True)


class SpidersJobsStatsSerializer(GlobalStatsSerializer):
class SpidersStatsSerializer(ProjectStatsSerializer):
pass


class SpiderPaginationSerializer(serializers.Serializer):
count = serializers.IntegerField()
next = serializers.HyperlinkedIdentityField(
view_name="project-stats", allow_null=True
)
previous = serializers.HyperlinkedIdentityField(
view_name="project-stats", allow_null=True
)
results = SpiderSerializer(many=True)


class JobsPaginationSerializer(serializers.Serializer):
count = serializers.IntegerField()
next = serializers.HyperlinkedIdentityField(
view_name="project-stats", allow_null=True
)
previous = serializers.HyperlinkedIdentityField(
view_name="project-stats", allow_null=True
)
results = SpidersJobsStatsSerializer(many=True)
4 changes: 2 additions & 2 deletions estela-api/api/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
)
router.register(
prefix=r"stats/(?P<pid>[0-9a-z-]+)",
viewset=stats_views.GlobalStatsViewSet,
basename="global-stats",
viewset=stats_views.ProjectStatsViewSet,
basename="project-stats",
)
router.register(
prefix=r"stats/(?P<pid>[0-9a-z-]+)/spider/(?P<sid>\d+)",
Expand Down