BITMAKER-3465 Stats module: Apply pagination to jobs per day in estela #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated viewsets names
…ndable feature on the stats table
mgonnav
requested changes
Jul 7, 2023
webtaken
commented
Jul 7, 2023
mgonnav
approved these changes
Jul 10, 2023
joaquingx
approved these changes
Jul 10, 2023
webtaken
added a commit
that referenced
this pull request
Jul 13, 2023
#204) * Added spiders endpoint to global stats and modified the stats serializers schema * Fixed issues with api generation, changed some schema responses and updated viewsets names * Added jobs action method to spiders viewset * Added the integration in frontend with the backend, disabled the expandable feature on the stats table * Disabling expandable row on stats table section * Fix issues mentioned on my reviewer's comments
webtaken
added a commit
that referenced
this pull request
Jul 17, 2023
#204) * Added spiders endpoint to global stats and modified the stats serializers schema * Fixed issues with api generation, changed some schema responses and updated viewsets names * Added jobs action method to spiders viewset * Added the integration in frontend with the backend, disabled the expandable feature on the stats table * Disabling expandable row on stats table section * Fix issues mentioned on my reviewer's comments
webtaken
added a commit
that referenced
this pull request
Jul 19, 2023
* BITMAKER-3465 Stats module: Apply pagination to jobs per day in estela (#204) * Added spiders endpoint to global stats and modified the stats serializers schema * Fixed issues with api generation, changed some schema responses and updated viewsets names * Added jobs action method to spiders viewset * Added the integration in frontend with the backend, disabled the expandable feature on the stats table * Disabling expandable row on stats table section * Fix issues mentioned on my reviewer's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
When the user wants the stats for the jobs executed in a specific date we need to provide a paginated result since the amount of jobs executed in a day could be huge. We'll organize this type of pagination by spiders executed in an specific date (paginated also) and then fetching jobs of those spiders (specific spider) executed that date.
Completion criteria:
Note (https://tasks.bitmaker.dev/issues/3465#note-1):
The branchs we will merge on stats-module branch will be https://tasks.bitmaker.dev/issues/3465 and https://tasks.bitmaker.dev/issues/3384.
Issue
Checklist before requesting a review