Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify ServiceMonitor annotations #635

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Allow to specify ServiceMonitor annotations #635

merged 3 commits into from
Jan 13, 2022

Commits on Jan 4, 2022

  1. Allow to specify ServiceMonitor annotations 

    Usecase: When installing with ArgoCD, Prometheus operator
(and associated CRDs) may be missing.

Adding the following in the values will allow creating the other
resources:

serviceMonitor:
  annotations:
    argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true

Ref: https://argoproj.github.io/argo-cd/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types
    @sathieu
    sathieu committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7e3891c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Apply suggestions from code review

    Juan Ariza Toledano committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    01c95f7 View commit details
    Browse the repository at this point in the history

  2. Update Chart.yaml 

    Avoid bumping chart version, it'll be bumped when including the new `v0.17.2` binaries
    Juan Ariza Toledano committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    c4baa06 View commit details
    Browse the repository at this point in the history