Allow to specify ServiceMonitor annotations #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathieu
force-pushed
the
servicemonitor-annotations
branch
from
3e1896a
to
1d116e8
Compare
|
@mkmik Please review. NB: I've not bumped the chart minor version as this is a feature addition. |
|
@juan131 Please review 🙏. |
|
@sathieu the new major version was just released! Please feel to rebase this branch in your fork with the latest changes in the main branch, and update this PR. |
sathieu
changed the title
sathieu
force-pushed
the
servicemonitor-annotations
branch
from
1d116e8
to
aa635f9
Compare
sathieu
requested review from
agarcia-oss,
alvneiayu,
juan131 and
mkmik
as code owners
|
@juan131 Thanks. I've reworked and pushed the PR. Please review 🙏 ! |
juan131
reviewed
Dec 23, 2021
Usecase: When installing with ArgoCD, Prometheus operator
(and associated CRDs) may be missing.
Adding the following in the values will allow creating the other
resources:
serviceMonitor:
annotations:
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
Ref: https://argoproj.github.io/argo-cd/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types
sathieu
force-pushed
the
servicemonitor-annotations
branch
from
aa635f9
to
7e3891c
Compare
|
@juan131 Anything missing in this PR? |
Avoid bumping chart version, it'll be bumped when including the new `v0.17.2` binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase: When installing with ArgoCD, Prometheus operator
(and associated CRDs) may be missing.
Adding the following in the values will allow creating the other
resources:
Ref: https://argoproj.github.io/argo-cd/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types