-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New chart major version #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <juanariza@vmware.com>
This was referenced Dec 16, 2021
Signed-off-by: juan131 <juanariza@vmware.com>
agarcia-oss
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @juan131 👏 👏 👏
alvneiayu
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @juan131. I included some suggestions but if you want to skip them it is ok. LGTM
Signed-off-by: juan131 <juanariza@vmware.com>
Signed-off-by: juan131 <juanariza@vmware.com>
Signed-off-by: juan131 <juanariza@vmware.com>
This was referenced Dec 16, 2021
Closed
This was referenced Jan 20, 2022
This was referenced Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 juanariza@vmware.com
Description of the change
These changes perform a major refactorization of the SealedSecrets Helm chart so it adopts several common practices and feature available in Bitnami charts.
The PR also updates the SealedSecrets version so it uses the latest available version:
0.17.1
Benefits
Possible drawbacks
Users will have to adapt their current values.yaml (or parameters passed via
--set
) to the new values structure.Applicable issues
Additional information
This PR also adapts the values.yaml to be compatible with the readme-generator tool.