Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chart major version #687

Merged
merged 5 commits into from
Dec 16, 2021
Merged

New chart major version #687

merged 5 commits into from
Dec 16, 2021

Conversation

juan131
Copy link
Collaborator

@juan131 juan131 commented Dec 16, 2021

Signed-off-by: juan131 juanariza@vmware.com

Description of the change

These changes perform a major refactorization of the SealedSecrets Helm chart so it adopts several common practices and feature available in Bitnami charts.

The PR also updates the SealedSecrets version so it uses the latest available version: 0.17.1

Benefits

  • Standardization
  • Compatible with new objects api versions.

Possible drawbacks

Users will have to adapt their current values.yaml (or parameters passed via --set) to the new values structure.

Applicable issues

Additional information

This PR also adapts the values.yaml to be compatible with the readme-generator tool.

Signed-off-by: juan131 <juanariza@vmware.com>
Signed-off-by: juan131 <juanariza@vmware.com>
Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @juan131 👏 👏 👏

Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @juan131. I included some suggestions but if you want to skip them it is ok. LGTM

helm/sealed-secrets/templates/role-binding.yaml Outdated Show resolved Hide resolved
helm/sealed-secrets/templates/role-binding.yaml Outdated Show resolved Hide resolved
helm/sealed-secrets/templates/role-binding.yaml Outdated Show resolved Hide resolved
helm/sealed-secrets/templates/role.yaml Outdated Show resolved Hide resolved
helm/sealed-secrets/templates/role.yaml Outdated Show resolved Hide resolved
juan131 added 3 commits December 16, 2021 15:40
Signed-off-by: juan131 <juanariza@vmware.com>
Signed-off-by: juan131 <juanariza@vmware.com>
Signed-off-by: juan131 <juanariza@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sealed Secrets
  
Completed
Development

Successfully merging this pull request may close these issues.

Helm Chart 0.17.0
3 participants