Fix several bugs in servicemonitor #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvneiayu
requested review from
agarcia-oss,
juan131 and
mkmik
as code owners
juan131
approved these changes
Dec 16, 2021
jfrancisco0
reviewed
Dec 16, 2021
| {{- else }} | ||
| namespace: {{ include "sealed-secrets.namespace" . }} | ||
| {{- end }} | ||
| labels: {{- include "sealed-secrets.labels" . | nindent 4 }} | ||
| {{- if .Values.serviceMonitor.labels }} | ||
| {{- include "sealed-secrets.render" ( dict "value" .Values.serviceMonitor.labels "context" $) | nindent 4 }} | ||
| {{- if .Values.metrics.serviceMonitor.labels }} |
There was a problem hiding this comment.
This is not documented in values.yaml or the README :)
sathieu
reviewed
Dec 17, 2021
Comment on lines
+14
to
+15
| - name: http | ||
| port: {{ .Values.service.port }} |
There was a problem hiding this comment.
This breaks kubeseal until #648 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
After we did the major release, the chart has several issues inside the service monitor. This patch fixes them.
Applicable issues