Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] add support for helm parameter maps for extraConfig #25646

Closed
rubenvw-ngdata opened this issue May 8, 2024 · 3 comments · Fixed by #26342
Closed

[bitnami/kafka] add support for helm parameter maps for extraConfig #25646

rubenvw-ngdata opened this issue May 8, 2024 · 3 comments · Fixed by #26342
Assignees

Comments

@rubenvw-ngdata
Copy link
Contributor

rubenvw-ngdata commented May 8, 2024

Name and Version

bitnami/kafka 28.1.1

What is the problem this feature will solve?

With the migration to Kafka 3.5, an extraConfig parameter was added to the chart.
We regret that this is just a text value instead of a helm parameter map.
This choice blocks the overloading of a certain setting via additional values.yaml layers.
With the current implementation, you need to duplicate all extraConfig if you want to change a single parameter in it.

As an example, instead of this

extraConfig: |
  max.message.bytes = 1048576
  offsets.topic.replication.factor = 3
  default.replication.factor = 3
  delete.topic.enable = true
  auto.create.topics.enable = false

we would prefer to have

extraConfig:
  max.message.bytes: 1048576
  offsets.topic.replication.factor: 3
  default.replication.factor: 3
  delete.topic.enable: true
  auto.create.topics.enable: false

to allow overloading.

What is the feature you are proposing to solve the problem?

helm parameter maps to allow overloading the extraConfig.

@rubenvw-ngdata rubenvw-ngdata changed the title [bitnami/kafka] add support for helm configuration maps for extraConfig [bitnami/kafka] add support for helm parameter maps for extraConfig May 8, 2024
@github-actions github-actions bot added the triage Triage is needed label May 8, 2024
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

@carrodher carrodher added the kafka label May 8, 2024
rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 22, 2024
Use a yaml parameter map instead of a flat file for the extraConfig
parameter. This allows for easier overloading both between the default
and broker / controller values; and between multiple values.yaml.
rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 22, 2024
Use a yaml parameter map instead of a flat file for the extraConfig
parameter. This allows for easier overloading both between the default
and broker / controller values; and between multiple values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
@rubenvw-ngdata
Copy link
Contributor Author

Hi @carrodher, I created a PR to add this. Let me know what you think.

rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 22, 2024
Use a yaml parameter map instead of a flat file for the extraConfig
parameter. This allows for easier overloading both between the default
and broker / controller values; and between multiple values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 30, 2024
Allow to use a yaml parameter map next to the flat file for the
extraConfig parameter. This is added as a separate parameter
extraConfigYaml. This allows for easier overloading both between
the default and broker / controller values; and between multiple
values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 30, 2024
Allow to use a yaml parameter map next to the flat file for the
extraConfig parameter. This is added as a separate parameter
extraConfigYaml. This allows for easier overloading both between
the default and broker / controller values; and between multiple
values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 30, 2024
Allow to use a yaml parameter map next to the flat file for the
extraConfig parameter. This is added as a separate parameter
extraConfigYaml. This allows for easier overloading both between
the default and broker / controller values; and between multiple
values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
rubenvw-ngdata added a commit to NGDATA/bitnami-charts that referenced this issue May 30, 2024
Allow to use a yaml parameter map next to the flat file for the
extraConfig parameter. This is added as a separate parameter
extraConfigYaml. This allows for easier overloading both between
the default and broker / controller values; and between multiple
values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
migruiz4 pushed a commit that referenced this issue May 30, 2024
Allow to use a yaml parameter map next to the flat file for the
extraConfig parameter. This is added as a separate parameter
extraConfigYaml. This allows for easier overloading both between
the default and broker / controller values; and between multiple
values.yaml.

Signed-off-by: Ruben Van Wanzeele <rubenvw@ngdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants