Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis-cluster] add support to disable persistence and add custom config #13545

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

anessi
Copy link
Contributor

@anessi anessi commented Nov 16, 2022

Description of the change

  • Adds support to disable persistence (uses emptyDir instead of a PVC). This is required if one wants to use Redis with in-memory data only. It makes sense to disable AOF and RDB persistence in the config in that case.
    # Disable AOF and RDB persistence as we keep everything in memory only, see https://redis.io/topics/persistence
    appendonly no
    # Disable RDB persistence, AOF persistence already disabled above.
    save ""
  • Adds support to supply a custom Redis configuration, e.g. to support an older version of Redis. With the current setup the config is hard-coded and not backwards compatible, so the current chart version can't be used with an older version or Redis.

Benefits

Adds additional features already covered, e.g. in the bitnami/redis chart. Does not change the default behavior and the changes are fully backwards compatible.

Possible drawbacks

Additional complexity

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

allow overriding of default Redis configuration

Signed-off-by: anessi <16045045+anessi@users.noreply.github.com>
@bitnami-bot bitnami-bot added this to Triage in Support Nov 16, 2022
@github-actions github-actions bot added the triage Triage is needed label Nov 16, 2022
@javsalgar javsalgar added the verify Execute verification workflow for these changes label Nov 16, 2022
@javsalgar javsalgar moved this from Triage to In progress in Support Nov 16, 2022
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Nov 16, 2022
@bitnami-bot bitnami-bot removed the request for review from javsalgar November 16, 2022 15:45
@marcosbc marcosbc changed the title [bitnami/redis-cluster] add support to disable persistence [bitnami/redis-cluster] add support to disable persistence and add custom config Nov 17, 2022
Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@marcosbc marcosbc merged commit eba6b1b into bitnami:main Nov 17, 2022
@bitnami-bot bitnami-bot moved this from In progress to Solved in Support Nov 17, 2022
ausias-armesto pushed a commit to ausias-armesto/charts that referenced this pull request Jan 10, 2023
…stom config (bitnami#13545)

Signed-off-by: anessi <16045045+anessi@users.noreply.github.com>
Signed-off-by: ausias-armesto <ausiasarmesto@gmail.com>
@fmulero fmulero removed this from Solved in Support Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis-cluster solved verify Execute verification workflow for these changes
Projects
None yet
3 participants