Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/common] render labels correctly when they contain templates #19680

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[bitnami/common] render labels correctly when they contain templates #19680

merged 1 commit into from
Oct 4, 2023

Conversation

jouve
Copy link
Contributor

@jouve jouve commented Oct 2, 2023 •
edited
Loading

Description of the change

pass correct context (.context instead of .) inside common.labels.standard.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@jouve
[bitnami/common] render labels correctly when they contains templates
6a4649c 
Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
@github-actions github-actions bot added the common label Oct 2, 2023
@bitnami-bot bitnami-bot added this to Triage in Support Oct 2, 2023
@github-actions github-actions bot moved this from Triage to In progress in Support Oct 2, 2023
@github-actions github-actions bot added the triage Triage is needed label Oct 2, 2023
@jouve jouve changed the title [bitnami/common] render labels correctly when they contains templates [bitnami/common] render labels correctly when they contain templates Oct 2, 2023
@javsalgar javsalgar moved this from In progress to Triage in Support Oct 3, 2023
@javsalgar javsalgar moved this from Triage to In progress in Support Oct 3, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Oct 3, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar October 3, 2023 07:50
FraPazGal
FraPazGal approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jouve! LGTM

@FraPazGal FraPazGal merged commit 3cb44e3 into bitnami:main Oct 4, 2023
8 checks passed
@bitnami-bot bitnami-bot moved this from In progress to Solved in Support Oct 4, 2023
jouve added a commit to jouve/charts that referenced this pull request Oct 4, 2023
@jouve
integrate bitnami/common 3.13.1 (bitnami/charts#19680)
c59d19f
@jouve jouve mentioned this pull request Oct 4, 2023
Closed
@jouve jouve deleted the labels branch October 5, 2023 21:32
@github-actions github-actions bot removed this from Solved in Support Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraPazGal FraPazGal FraPazGal approved these changes

Assignees

@FraPazGal FraPazGal

Labels
common solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jouve @FraPazGal @javsalgar