[bitnami/*] Skip image's tag in the README files of the Bitnami Charts #19841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jotamartos
force-pushed
the
skip-image-tag-README
branch
from
0af189d
to
0b8b2ec
Compare
carrodher
approved these changes
Oct 19, 2023
carrodher
previously approved these changes
Oct 20, 2023
Signed-off-by: Jota Martos <jotamartos@vmware.com>
jotamartos
force-pushed
the
skip-image-tag-README
branch
from
0b8b2ec
to
52c953a
Compare
Signed-off-by: Jota Martos <jotamartos@vmware.com>
carrodher
previously approved these changes
Oct 20, 2023
Signed-off-by: Jota Martos <jotamartos@vmware.com>
carrodher
approved these changes
Oct 20, 2023
2 tasks
|
For certain charts such as MySQL, where I require 5.7 and not 8.0, would I still be using image.tag to override the image version even though it's no longer explicitly stated in the README? |
|
Yes yes, this change only affects the README table, the values themselves and their usage were not modified. |
4 tasks
garettmd
pushed a commit
to garettmd/odoo
that referenced
this pull request
Jan 31, 2024
bitnami#19841) * [bitnami/*] Skip image's tag in the README files of the Bitnami Charts Signed-off-by: Jota Martos <jotamartos@vmware.com> * [bitnami/*] Improve validation Signed-off-by: Jota Martos <jotamartos@vmware.com> * [bitnami/*] Improve validation Signed-off-by: Jota Martos <jotamartos@vmware.com> --------- Signed-off-by: Jota Martos <jotamartos@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In order to standardize the documentation, we would like to remove the images' tag information from the README files. This change is related to this other previous PR #19835
Benefits
Make the documentation neutral for all distros
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm