Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] feat: ✨ Remove empty seLinuxOptions in adapted Openshift rendered security context #24268

Merged

Conversation

javsalgar
Copy link
Contributor

Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com

Description of the change

This PR removes empty seLinuxOptions in Openshift environments, as this is causing problems when performing validation.

Initially, we set it to null to workaround this incompatibility with this was causing problems in non-openshift environments. This new adapter should fix the issue.

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…hift rendered security context

Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
@github-actions github-actions bot added the common label Mar 8, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 8, 2024
@github-actions github-actions bot requested a review from dgomezleon March 8, 2024 08:43
@alemorcuq alemorcuq merged commit 1f2f5ef into main Mar 8, 2024
19 checks passed
@alemorcuq alemorcuq deleted the feature/common-compatibility-removeselinuxinopenshift branch March 8, 2024 09:12
@github-actions github-actions bot added the solved label Mar 8, 2024
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami common solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/kube-prometheus] seLinuxOptions defaults are not valid
5 participants