-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/mediawiki] feat!: 🔒 💥 Improve security defaults #24771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
4 tasks
dgomezleon
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: David Gomez <dgomezleon@vmware.com>
dgomezleon
previously approved these changes
Apr 3, 2024
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
dgomezleon
force-pushed
the
feature/mediawiki-security-major
branch
from
April 3, 2024 09:44
00ecbc6
to
87684e4
Compare
dgomezleon
previously approved these changes
Apr 3, 2024
Signed-off-by: David Gomez <dgomezleon@vmware.com>
dgomezleon
force-pushed
the
feature/mediawiki-security-major
branch
from
April 3, 2024 09:56
87684e4
to
98ff74a
Compare
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
dgomezleon
approved these changes
Apr 3, 2024
djjudas21
pushed a commit
to djjudas21/bitnami-charts
that referenced
this pull request
Apr 17, 2024
* [bitnami/mediawiki] feat!: 🔒 💥 Improve security defaults Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * [bitnami/mediawiki] Update MariaDB to branch 11.3 Signed-off-by: David Gomez <dgomezleon@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * [bitnami/mediawiki] Update deps Signed-off-by: David Gomez <dgomezleon@vmware.com> * [bitnami/mediawiki] Fix typo Signed-off-by: David Gomez <dgomezleon@vmware.com> * fix: 🐛 Use .containerPort in networkPolicy Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> --------- Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: David Gomez <dgomezleon@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: David Gomez <dgomezleon@vmware.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com
Description of the change
This major bump changes the following security defaults:
runAsGroup
is changed from0
to1001
readOnlyRootFilesystem
is set totrue
resourcesPreset
is changed fromnone
to the minimum size working in our test suites (NOTE:resourcesPreset
is not meant for production usage, butresources
adapted to your use case).global.compatibility.openshift.adaptSecurityContext
is changed fromdisabled
toauto
.networkPolicy
section has been normalized amongst all Bitnami charts. Compared to the previous approach, the values section has been simplified (check the Parameters section) and now it set toenabled=true
by default. Egress traffic is allowed by default and ingress traffic is allowed by all pods but only to the ports set incontainerPorts
andextraContainerPorts
.Benefits
Possible drawbacks
This could potentially break any customization or init scripts used in your deployment. If this is the case, change the default values to the previous ones.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm