[bitnami/ghost] feat!: 🔒 💥 Improve security defaults #24785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
juan131
reviewed
Apr 3, 2024
Comment on lines
+68
to
+94
| - name: prepare-base-dir | ||
| image: {{ include "ghost.image" . }} | ||
| imagePullPolicy: {{ .Values.image.pullPolicy | quote }} | ||
| {{- if .Values.resources }} | ||
| resources: {{- toYaml .Values.resources | nindent 12 }} | ||
| {{- else if ne .Values.resourcesPreset "none" }} | ||
| resources: {{- include "common.resources.preset" (dict "type" .Values.resourcesPreset) | nindent 12 }} | ||
| {{- end }} | ||
| {{- if .Values.containerSecurityContext.enabled }} | ||
| securityContext: {{- include "common.compatibility.renderSecurityContext" (dict "secContext" .Values.containerSecurityContext "context" $) | nindent 12 }} | ||
| {{- end }} | ||
| command: | ||
| - /bin/bash | ||
| args: | ||
| - -ec | ||
| - | | ||
| #!/bin/bash | ||
|
|
||
| . /opt/bitnami/scripts/liblog.sh | ||
|
|
||
| info "Copying base dir to empty dir" | ||
| # In order to not break the application functionality (such as upgrades or plugins) we need | ||
| # to make the base directory writable, so we need to copy it to an empty dir volume | ||
| cp -r --preserve=mode /opt/bitnami/ghost /emptydir/app-base-dir | ||
| volumeMounts: | ||
| - name: empty-dir | ||
| mountPath: /emptydir |
There was a problem hiding this comment.
Ghost does not use apache, and Ghost already prints to stdout
juan131
reviewed
Apr 3, 2024
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
djjudas21
pushed a commit
to djjudas21/bitnami-charts
that referenced
this pull request
Apr 17, 2024
* [bitnami/ghost] feat!: 🔒 💥 Improve security defaults Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * fix: 🐛 Use .containerPort in networkPolicy Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> --------- Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com
Description of the change
This major bump changes the following security defaults:
runAsGroupis changed from0to1001readOnlyRootFilesystemis set totrueresourcesPresetis changed fromnoneto the minimum size working in our test suites (NOTE:resourcesPresetis not meant for production usage, butresourcesadapted to your use case).global.compatibility.openshift.adaptSecurityContextis changed fromdisabledtoauto.Benefits
Possible drawbacks
This could potentially break any customization or init scripts used in your deployment. If this is the case, change the default values to the previous ones.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm