[bitnami/valkey-cluster] Add valkey cluster chart #27737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
rafariossaa
force-pushed
the
add_valkey_cluster
branch
from
3b09a52
to
9f4e934
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
rafariossaa
force-pushed
the
add_valkey_cluster
branch
from
2e84872
to
040e8fd
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
carrodher
changed the title
fmulero
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thanks a lot @rafariossaa !!
I left some comments, could you give it a glance?
Comment on lines
+46
to
+48
| {{- if semverCompare ">= 1.13" (include "common.capabilities.kubeVersion" .) }} | ||
| enableServiceLinks: false | ||
| {{- end }} |
There was a problem hiding this comment.
According to our README file, we support versions 1.23+. I think this condition is not needed and we could allow users change this value
Co-authored-by: Fran Mulero <francisco-jose.mulero@broadcom.com> Signed-off-by: Rafael Ríos Saavedra <rafael.rios.saavedra@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
rafariossaa
force-pushed
the
add_valkey_cluster
branch
from
ad71b90
to
73e44f5
Compare
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
rafariossaa
force-pushed
the
add_valkey_cluster
branch
from
73e44f5
to
9006b84
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
approved these changes
Jul 5, 2024
| @@ -0,0 +1,57 @@ | |||
| module test-redis-chart | |||
There was a problem hiding this comment.
Suggested change
| module test-redis-chart | |
| module test-valkey-cluster-chart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds chart for
valkey-clusterBenefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm