Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kubewatch] add MS Teams config #3189

Merged
merged 1 commit into from Jul 23, 2020

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Jul 22, 2020

Description of the change

Exposes Microsoft Teams configuration for kubewatch in values.yaml file for ease of configuration.

Benefits

Use bespoke MSTeams support in kubewatch rather than generic webhook support. Yields better output in client.

Possible drawbacks

None.

Applicable issues

Additional information

I followed the pattern from #3024.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@marcosbc marcosbc merged commit 8b11fce into bitnami:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants