[bitnami/minio] Update minio-env.sh to allow custom path for persist #55562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrodher
added
verify
FraPazGal
reviewed
Feb 1, 2024
| @@ -78,6 +78,7 @@ export MINIO_DISTRIBUTED_MODE_ENABLED="${MINIO_DISTRIBUTED_MODE_ENABLED:-no}" | |||
| export MINIO_DEFAULT_BUCKETS="${MINIO_DEFAULT_BUCKETS:-}" | |||
| export MINIO_STARTUP_TIMEOUT="${MINIO_STARTUP_TIMEOUT:-10}" | |||
| export MINIO_SERVER_URL="${MINIO_SERVER_URL:-$MINIO_SCHEME://localhost:$MINIO_API_PORT_NUMBER}" | |||
| export MINIO_DATA_DIR="${MINIO_DATA_DIR:-/bitnami/minio/data}" | |||
There was a problem hiding this comment.
Minor nitpick; could you move it back to the path section? It's true it could also be considered part of MinIO config but having all the path-related envs grouped seems more intuitive to me.
There was a problem hiding this comment.
Sure! I was 50/50 on where this should go in here as everything in the "path" section is non-configurable, but this is still a path, but now it is a configurable path!
There was a problem hiding this comment.
@FraPazGal Bumping this
There was a problem hiding this comment.
Perfect, the PR LGTM @Mo0rBy! Let me run a couple of check in our internal pipeline before merging this.
…nce directory and updated README.md Signed-off-by: Will Moorby <will.moorby2@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nce directory and updated README.md
Description of the change
This change allows the
MINIO_DATA_DIRenvironment variable to be a configurable value so that the persistence directory can exist at a path inside the container that is not/bitnami/minio/data.Benefits
This allows users to have a persistence directory that is not the default
bitnami/minio/datapath so that mounting the persistence volume to something like AWS EFS or EBS can be done with naming conventions suited to the user/team.Possible drawbacks
This is very small change, I honestly can't think of any apart from something to check while troubleshooting/debugging.
Applicable issues
My own issue created in
bitnami/charts> bitnami/charts#21757 (I will be looking at creating a Helm chart PR in the next few days as well, when I get time).Additional information
I tested this by running the container image locally, going into the UI and creating a new bucket called
test-bucketand you can see that when I shell into the container, there is atest-bucketdirectory created at the custom persistence path.Here is a screenshot of my terminal to prove that the bucket exists in the correct place (inside
custom-data-dir):I would not consider this a limitation but this configuration requires that the user deploying the container must have the container path mount and the environment variables as the same value. This is ONLY when configuring the container to use a custom persistence path, the default
/bitnami/minio/datacan still be used. I have updated the relevant section of theREADME.mdwhich explains.