[bitnami/minio] Added MINIO_DATA_DIR envVar to standalone and distributed charts that… #23388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use the value of persistence.mountPath Signed-off-by: Will Moorby <will.moorby2@gmail.com>
carrodher
added
verify
joancafom
pushed a commit
to dalbani/charts
that referenced
this pull request
Feb 22, 2024
… use the value of persistence.mountPath (bitnami#23388) Signed-off-by: Will Moorby <will.moorby2@gmail.com> Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… uses the value of
persistence.mountPathDescription of the change
The changes in this PR make the
persistence.mountPathvalue get passed into the MinIO container environment variableMINIO_DATA_DIRsuch that data stored within MinIO is stored within the mounted PV and it is persisted correctly.The relevant PR for the MinIO image that allows the
MINIO_DATA_DIRenvVar to be configured can be seen here.Benefits
This change make it easier to configure persistence for the MinIO deployment. It makes sense that the
persistence.mountPathdirectory should be used for the persistence of data and making this change means that theMINIO_DATA_DIRenvVar is not required within theextraEnvVarssection to achieve proper persistence.Possible drawbacks
N/A
Applicable issues
Addresses #21757
Additional information
I now that this will definitely work for a Standalone deployment, but I'm not so sure about my changes to the Distributed deployment. I would be happy to revert those changes within the
distributed/statefulset.yamlfile, but I know thestandalone/deployment.yamlchanges work.Here is some evidence of the
helm templatecommand with this value set to show the resulting deployment template:No extra values have been added, but I have updated the relevant README section a little bit.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm