You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if(fullName!=="string")// should be if(typeof(fullName)!=='string')
line 1099:
if(typeof(fullName)!=="string"){//this is already corrected according to 1.protoProps=staticProps;staticProps=fullName;}
if there is no full name specified proto properties will become static properties and static properties will become null (for some reason fullName is always provided even if it is null)
This will lead to the problem with parseModel/parseModels:
I think that code should no longer be there.
// If there was no prototype, or no `model` and no `parseModel`,
// we'll have to create a `parseModel`.
else if (!protoProps || (!protoProps[name] && !protoProps[parseName])) {
can.Construct._overwrite(self, base, parseName, parsers[parseName]());
}
protoProps should be replaced with staticProps since parseModel/parseModels seats in static properties, not proto properties.
The text was updated successfully, but these errors were encountered:
ghost
changed the title
typo in model.js breaks functionality
Multiple issues with Model
Jun 1, 2014
From the code model.js
line 1099:
line 1099:
if there is no full name specified proto properties will become static properties and static properties will become null (for some reason fullName is always provided even if it is null)
This will lead to the problem with parseModel/parseModels:
I think that code should no longer be there.
line 1228:
protoProps should be replaced with staticProps since parseModel/parseModels seats in static properties, not proto properties.
The text was updated successfully, but these errors were encountered: