Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis.yml before_script #1418

Closed
alexisabril opened this issue Jan 30, 2015 · 3 comments
Closed

travis.yml before_script #1418

alexisabril opened this issue Jan 30, 2015 · 3 comments
Assignees
@mjstahl
Labels
bug easy
Milestone
2.2.0

Comments

@alexisabril
Copy link
Contributor

We'll need to modify https://github.com/bitovi/canjs/blob/minor/.travis.yml#L3 from:

npm install jquery#1.11.0 && node_modules/.bin/bower install

to

node_modules/.bin/bower install

and add jquery@1.11.0 to the package.json.

Currently to run CanJS tests locally on this branch you'll need to run npm install, then npm install jquery... prior to npm tests. npm install jquery... should not be necessary or hidden.
@mjstahl mjstahl self-assigned this Jan 30, 2015
mjstahl pushed a commit that referenced this issue Jan 30, 2015
Moved jquery out of travis.yml file and into devDependencies #1418
e2485ef
daffl added a commit that referenced this issue Feb 4, 2015
@daffl
Merge pull request #1421 from bitovi/1418-move-jquery
c53a357 
Moved jquery out of travis.yml file and into devDependencies #1418
@mjstahl mjstahl mentioned this issue Feb 5, 2015
Merged
@daffl daffl added this to the 2.2.0 milestone Feb 13, 2015
@daffl daffl closed this as completed Feb 13, 2015
@justinbmeyer
Copy link
Contributor

@alexisabril You shouldn't have to run npm install jquery for a peerDep. npm will install peerDeps.

@daffl
Copy link
Contributor

daffl commented Feb 18, 2015

This caused tons of issue with people forgetting to run it locally. I think we should be able to make it a peer and dev-dependency.

@daffl
Copy link
Contributor

daffl commented Feb 18, 2015

Nevermind, peerDependencies actually are being installed and @mjstahl is going to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjstahl mjstahl

Labels
bug easy
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@justinbmeyer @alexisabril @mjstahl @daffl