New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml before_script #1418

Closed
alexisabril opened this Issue Jan 30, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@alexisabril
Contributor

alexisabril commented Jan 30, 2015

We'll need to modify https://github.com/bitovi/canjs/blob/minor/.travis.yml#L3 from:

npm install jquery#1.11.0 && node_modules/.bin/bower install

to

node_modules/.bin/bower install

and add jquery@1.11.0 to the package.json.

Currently to run CanJS tests locally on this branch you'll need to run npm install, then npm install jquery... prior to npm tests. npm install jquery... should not be necessary or hidden.

@mjstahl mjstahl self-assigned this Jan 30, 2015

daffl added a commit that referenced this issue Feb 4, 2015

Merge pull request #1421 from bitovi/1418-move-jquery
Moved jquery out of travis.yml file and into devDependencies #1418

@daffl daffl added this to the 2.2.0 milestone Feb 13, 2015

@daffl daffl closed this Feb 13, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Feb 18, 2015

Contributor

@alexisabril You shouldn't have to run npm install jquery for a peerDep. npm will install peerDeps.

Contributor

justinbmeyer commented Feb 18, 2015

@alexisabril You shouldn't have to run npm install jquery for a peerDep. npm will install peerDeps.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Feb 18, 2015

Contributor

This caused tons of issue with people forgetting to run it locally. I think we should be able to make it a peer and dev-dependency.

Contributor

daffl commented Feb 18, 2015

This caused tons of issue with people forgetting to run it locally. I think we should be able to make it a peer and dev-dependency.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Feb 18, 2015

Contributor

Nevermind, peerDependencies actually are being installed and @mjstahl is going to update this.

Contributor

daffl commented Feb 18, 2015

Nevermind, peerDependencies actually are being installed and @mjstahl is going to update this.

@daffl daffl removed the fixed in branch label Feb 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment