Adds support for EJS shared blocks #242 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transforms the EJS template to add support for shared blocks.
Essentially, this breaks up EJS tags into multiple EJS tags if they
contained unmatched brackets.
For example, this doesn't work:
<% if (1) { %><% if (1) { %> hi <% } } %>
...without isolated EJS blocks:
<% if (1) { %><% if (1) { %> hi <% } %><% } %>
The result of transforming:
<% if (1) { %><% %><% if (1) { %><% %> hi <% } %><% } %>
|
Please review these changes before we merge this @justinbmeyer @ccummings @daffl Do you foresee any issues with these changes? |
|
This commit should be included in the final build for JMVC 3.3. |
…#242 For some reason a template loaded by file generates a different result than one loaded by string.
|
This now fixes the issues that I was having (non-isolated blocks of code breaking), but still doesn't fix the original issue for #242 (losing variables). |
andykant
added a commit
that referenced
this pull request
May 13, 2013
Adds support for EJS shared blocks #242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforms the EJS template to add support for shared blocks. Essentially, this breaks up EJS tags into multiple EJS tags if they contained unmatched brackets.
These types of templates previously worked prior to adding live binding support to EJS. It also isn't obvious that they shouldn't work and can cause issues if you don't know about this quirk.
For example, this doesn't work:
...without isolated EJS blocks:
The result of transforming: