You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but what about 2 years later, if a system is still using that Can.js file, when querying what can.js version it is, it will still say @EDGE, when can.js probably is 2.0 or higher.
The text was updated successfully, but these errors were encountered:
You are right, this was added as a fix to #316. I posed a similar question in that issue about what the GitHub version of CanJS should output as its VERSION. We were trying to avoid updating the version by hand, but you raise a good point.
Most complex projects like ours always force you to use a built version of their library. For example, you'd never use the files in the src directory of jquery. You make your modifications, do a build and use the output of the build. But with CanJS, you do use the src files if you want to use steal.
So we either 1) accept that VERSION will be inaccurate or 2) update the VERSION by hand or 3) Make a built steal version of CanJS similar to how we have a version for AMD.
I actually like 3 because there are lots of documentation, demo pages and tests in the GitHub source and a clean steal build might be nice. It makes working with CanJS similar to working with jQuery or any other relatively large library. You have source files, but the files you use in your application are the result of a build step.
I think the main issue that @jianlin was mentioning is that @EDGE didn't get replaced with the actual version in the release files (https://github.com/bitovi/canjs.com). I will update that as well as adding construct/proxy again. I also agree that we should have a clean Steal release in there as well.
Right now, I think Can.js 1.1.6 added this:
can.VERSION is
@EDGE
but what about 2 years later, if a system is still using that Can.js file, when querying what can.js version it is, it will still say
@EDGE
, when can.js probably is2.0
or higher.The text was updated successfully, but these errors were encountered: