Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended syntax breaks can.route #462

Closed
shcarrico opened this issue Aug 21, 2013 · 1 comment
Closed

recommended syntax breaks can.route #462

shcarrico opened this issue Aug 21, 2013 · 1 comment

Comments

@shcarrico
Copy link
Contributor

The documentation for http://canjs.com/docs/can.route.html has several inconsistencies:

! (hash-bang) is entered as !# (bang-hash) in multiple places

more importantly, can.route('#!foo/:id') breaks the pretty URL functionality of can.route. It should be can.route('foo/:id') without the hashbang..

This is not huge to fix, but is important as the recommended syntax causes the library to fail silently, producing 4 change events per update and a blank hash value...

@ghost ghost assigned imjoshdean Aug 21, 2013
@justinbmeyer
Copy link
Contributor

thanks, but we've been adding documentation errors to the canjs.com repo:

https://github.com/bitovi/canjs.com. Can you add this there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants