Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live-Binding memory leak #666

Closed
daniel-franz opened this issue Jan 15, 2014 · 1 comment · Fixed by #669
Closed

Live-Binding memory leak #666

daniel-franz opened this issue Jan 15, 2014 · 1 comment · Fixed by #669
Labels
bug
Milestone
2.0.5

Comments

@daniel-franz
Copy link
Contributor

It seems like there is a memory leak in live-binding as text-nodes are seemingly never removed from can.template.nodeLists.nodeMap. As text-nodes' parents don't have an attached nodeList they are never unbound.

Example: http://jsfiddle.net/y2BXn/1/
@justinbmeyer
Copy link
Contributor

I think this is a great catch. Here's a fiddle that shows it a bit more explicitly:

http://jsfiddle.net/donejs/y2BXn/2/

Thanks. I will fix this tonight.

justinbmeyer added a commit that referenced this issue Jan 16, 2014
@justinbmeyer
fixes #666 by registering the nodeList to be removed when the parent …
6d38a31 
…element is torn down
@justinbmeyer justinbmeyer mentioned this issue Jan 16, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.5
Development

Successfully merging a pull request may close this issue.

Fixes a memory leak with live binding. canjs/canjs
2 participants
@justinbmeyer @daniel-franz