nested component within an #if is not live bound #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisabril
pushed a commit
that referenced
this pull request
May 29, 2014
|
maybe is related to #1019 ? |
|
Very possible. I was looking that issue as well. I wrote another test as #if seems to work with other DOM elements, just seems to halt calling the helper in situations with a nested component. That being said, the logic to fix this very well maybe related. |
|
This is actually an issue with custom helpers as well. |
alexisabril
added a commit
that referenced
this pull request
May 30, 2014
|
@shcarrico I just tested this fix with #1019. They appear to be separate issues. #1025 turned out to be specific to stache. |
daffl
added a commit
that referenced
this pull request
Jun 9, 2014
nested component within an #if is not live bound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if around a child component, live binds on the initial change of a compute, however is not updated on subsequent compute updates. The parent component does receive compute change events correctly.