Making routes not greedily consume slashes by default #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed. |
|
I think there's something wrong with the build. Its not failing locally in the same place, it just randomly timed out. But it was also timing out when I ran it from master in another spot. |
|
I don't think that failure is actually related to this commit. |
|
I would make sure. |
…t adding a flag to turn this behavior off
update qunit and get rid of using steal.root in a test as it won't work in production
daffl
added a commit
that referenced
this pull request
Jun 13, 2014
Making routes not greedily consume slashes by default
|
@moschel can you add some docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to turn this behavior off. Also makes it so you can call .root with the domain included, which wasn't working before.
@justinbmeyer I looked through the route issues and didn't see anything related to this. Added a flag anyways (matchSlashes, which defaults to false) so if this breaks someone's code they can flip it off.