Fixed Mustache getHelper() so that it doesn't need second argument #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mustache getHelper('helpername') would not work unless you supplied an empty Observe/Map as second argument.
|
Assuming that this is for manually retrieving and calling helpers it looks ok I'll just have to add tests for it. |
|
@daffl I wrote a test for this https://github.com/bitovi/canjs/tree/test-1178, not sure how do you want to proceed, should I merge this PR in my branch? |
|
Yes, merge the the remote branch in and make sure tests pass. Then we can merge this PR and then yours. Also, we probably want this for Stacheh as well? |
daffl
added a commit
that referenced
this pull request
Nov 5, 2014
Fixed Mustache getHelper() so that it doesn't need second argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mustache getHelper('helpername') would not work unless you supplied an empty Observe/Map as second argument.