Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I could tell the Sort plugin was largely incomplete.
After a lot of work it now...
can.List
's sort order to the DOM{{#each}}
push
,unshift
, andsplice
add items at the correct index viacan.List._getInsertIndex()
(for efficiency there's no need to append then move an item)move
event (this used to result in aremove
andadd
event){{#each}}
helper move the underlying DOM nodes rather than removing and re-creating them (this is much faster).can.List._getInsertIndex
as opposed to a completecan.List.sort
operationcan.List
that have abatchNum
result in a completecan.List.sort
operation rather than (potentially) lots of far less efficientcan.List._getInsertIndex
operationscan.List.sort
operations when a partial sort is all that's needed to resolve the entirecan.List
's sort orderFuture goals:
Rough out documentation{{#each}}
dependenciesCloses #1404, #1114, #1265, #828