Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.List.prototype.sortIndexes is defined but not referenced #1404

Closed
akagomez opened this issue Jan 15, 2015 · 1 comment · Fixed by #1454
Closed

can.List.prototype.sortIndexes is defined but not referenced #1404

akagomez opened this issue Jan 15, 2015 · 1 comment · Fixed by #1454
Assignees
Milestone

Comments

@akagomez
Copy link
Contributor

sortIndexes is defined here:

https://github.com/bitovi/canjs/blob/8425837c343efd6828bba1040bdabdd26ab96bea/map/sort/sort.js#L31

But a search yields only one result:

totes:canjs akagomez$ grep -rn "sortIndexes" .
./map/sort/sort.js:31:      sortIndexes: [],

It's possible that it's referenced using some funky string concatenation, but that seems unlikely to me since sort.js itself doesn't utilize it.

@akagomez akagomez added the easy label Jan 15, 2015
@akagomez akagomez self-assigned this Feb 4, 2015
@justinbmeyer
Copy link
Contributor

Is this an issue to remove that definition? If so, and removing it causes no tests to fail, please remove it. Thanks!

@daffl daffl added this to the 2.2.0 milestone Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants