can.List.prototype.sortIndexes is defined but not referenced #1404

Closed
akagomez opened this Issue Jan 15, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@akagomez
Contributor

akagomez commented Jan 15, 2015

sortIndexes is defined here:

https://github.com/bitovi/canjs/blob/8425837c343efd6828bba1040bdabdd26ab96bea/map/sort/sort.js#L31

But a search yields only one result:

totes:canjs akagomez$ grep -rn "sortIndexes" .
./map/sort/sort.js:31:      sortIndexes: [],

It's possible that it's referenced using some funky string concatenation, but that seems unlikely to me since sort.js itself doesn't utilize it.

@akagomez akagomez added the easy label Jan 15, 2015

@akagomez akagomez self-assigned this Feb 4, 2015

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Feb 11, 2015

Contributor

Is this an issue to remove that definition? If so, and removing it causes no tests to fail, please remove it. Thanks!

Contributor

justinbmeyer commented Feb 11, 2015

Is this an issue to remove that definition? If so, and removing it causes no tests to fail, please remove it. Thanks!

@justinbmeyer justinbmeyer added the bug label Feb 11, 2015

@daffl daffl closed this in #1454 Feb 19, 2015

@daffl daffl added this to the 2.2.0 milestone Feb 19, 2015

@daffl daffl removed the fixed in branch label Feb 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment