can.Model Fails Silently When Server Doesn't Return an Array for findAll

[daffl]

No deferred method is executed if invalid data is returned. For example:

myModel.findAll({myData: 'myValue'}, function(result) {
    // do something here
}).fail(function(xhr, textStatus, errorThrown) {
  // do something here
});

Success callback or fail callback not called. This hold true for 'then'.

[daffl]

Could you verify this happening in all cases or just for cross domain requests as mentioned in #385? How did you implement findAll, update etc. in the cross domain case? Afaik, JSONP requests don't explicitly fail, you actually have to examine the response and fail the deferred yourself.

[maurerbot]

We made a fiddle to demonstrate this. Looks like the deferred is called with an ajax but not the model.

http://jsfiddle.net/mattseburn/vTnDS/1/

We aren't doing any cross domain requests. It was actually a coincidence that we noticed this behaviour because a local apache proxies wasn't set up. But it would be nice to know if a JSONP requests possible with can.Model to inspect the response?

[daffl]

Allright, the findAll and findOne deferreds now reject when an exception gets thrown during .model or .models conversion and the default .models throws an error if it can't convert the data (i.e. the data is undefined).

[justinbmeyer]

So was can.Model truly silently failing (no error in the console), or was the fail not called?

IMO, an error is a different case than a ajax request fails to load. I'm not sure the try-catch was ever appropriate.