Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.compute-friendly validations #410

Merged
merged 3 commits into from Jul 19, 2013
Merged

can.compute-friendly validations #410

merged 3 commits into from Jul 19, 2013

Conversation

daffl
Copy link
Contributor

@daffl daffl commented Jul 19, 2013

https://github.com/bitovi/canjs/blob/master/observe/validations/validations.js#L376 shows:

var res = func.call(self, isTest ? ( self.__convert ?
   self.__convert(attr, newVal) :
   newVal ) : self[attr]);

If self[attr] became self.attr(attr), it would allow can.computes to be constructed on can.Observes based on validations. Would this cause undesirable side effects?

daffl added a commit that referenced this pull request Jul 19, 2013
@daffl daffl merged commit 2460e7c into master Jul 19, 2013
@daffl daffl deleted the compute-validations-410 branch July 19, 2013 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants