Fixing error that occurs when an item in an Observe.List contains a comp... #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompute and is removed
|
Can you quickly merge latest master (which has CI fixed) into your feature branch and push to re-run the tests? Once they passed this is good to merge I think. |
daffl
added a commit
that referenced
this pull request
Jun 10, 2013
Fixing error that occurs when an item in an Observe.List contains a comp...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ute and is removed
If an Observe.List item contains a compute that does not have any bindings, removing that item from the list results in a JS error in compute.js
This occurs when the compute does not have any bindings, so
onis never called, leavingcomputedData === undefined.Fix is to check that computedData is truthy before calling teardown()