Functions globally defined when it shouldn't be #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major breakage.
|
@matthewp can you add more details? |
|
@justinbmeyer added an explanation. |
This fixes a few instances where variables were being attached to the window that are meant to be used only locally.
daffl
added a commit
that referenced
this pull request
Dec 11, 2013
Functions defined without being declared.
Merged
justinbmeyer
added a commit
that referenced
this pull request
Jan 23, 2014
andykant
added a commit
that referenced
this pull request
Jan 23, 2014
Fixes test for #604 so it works in IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
updateListandteardownListare meant to be local variables in this context but are added to the window due to not being declared. Causes hard to track down issues when you have multiple lists being bound at the time same time.