no doubled history states

[stevenvachon]

#587

[daffl]

Test?

[stevenvachon]

I'm not sure how to test this with anything other than what is seen. I had the same difficulty in #587. I tested back/forward and replacing history states; all works fine only now without doubling.

[justinbmeyer]

Is it possible to register a few changes in the history, then call .back() and see if the url stays the same?

[stevenvachon]

As I'd stated in #587, good idea; I'll create a test soon. I'm hoping that I can first fix the bug, though. The cause is can.route.attr's "change" event calling pushState too many times.

Solution(s):
Add a newURL != currentURL check in history.pushState
I'm, of course, open to better ideas.

Here is the flow:

// start
can.route.ready > can.route.setState

a.click >> anchorClickFix > history.pushState

// back and forward only
window.popstate >> can.route.setState


// overridden  function
history.pushState > can.route.setState

can.route.setState > can.route.attr

// onRouteDataChange is only called once, as it should be
can.route.attr > can.route.data > onRouteDataChange >> can.route.bindings.pushstate.setURL > history.pushState

[stevenvachon]

patch-3 was merged into this (patch-4)… patch-3 may conflict with #699
just a heads up to save any time