Changing can.Control.route to match pushstate (#612) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andykant
added a commit
that referenced
this pull request
Jan 23, 2014
Changing can.Control.route to match pushstate (#612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using can.Control.route with pushstate.js the events never fire because the selectors don't match those in pushstate.js. This is because before a route is added to can.route.routes it is stripped of any preceding forward slash. I've added the same check on line 9. This causes routes to match and controller events fire. This shouldn't affect routes using #! since those routes won't start with a forward slash.
See #612 for more information.