Ensure can-value bound input stay in sync with compute #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that when the compute value is set due to a user typing into an input, that the input's value is checked against the new value and that they are the same. Otherwise it is possible for the compute to reject the input's value (or set it to something else entirely) and the input and compute value become out of sync. Fixes canjs#887
| // Set the value of the attribute passed in to reflect what the user typed | ||
| this.options.value(this.element[0].value); | ||
| var newVal = this.options.value(el.value); |
There was a problem hiding this comment.
I don't think can.compute necessarily always returns its current value when being set. I would change this to:
this.options.value(el.value)
var newVal = this.options.value();
cklanac
added a commit
that referenced
this pull request
Feb 10, 2015
See conversation here: #888 (comment)
This was referenced Feb 10, 2015
|
Resubmitted as #1436 |
This was referenced Feb 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a
can-valuebound input to become out of sync with it's underlying data if that data is a compute with a setter function. The setter function might reject the user's input or set the value to something else entirely.Previously we were assuming that the compute's new value would always be the same as the input's value. This checks to make sure that the values are the same, otherwise it sets the input's value to reflect the actual value of the compute.
Fixes #887