Updated: Ensure can-value bound input stay in sync with compute #888 #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that when the compute value is set due to a user typing into an input, that the input's value is checked against the new value and that they are the same. Otherwise it is possible for the compute to reject the input's value (or set it to something else entirely) and the input and compute value become out of sync. Fixes #887
Using steal-tools to do the pluginify builds
…into system-steal-domless
This updates the gruntfile to correctly reflect how options should be passed into the builder: `main` and `config` are part of the `steal` options object. Also, main is needed so that will be used as the entry point instead of Grunt's `files`.
Previously the steal build wasn't getting can/util/util.js because in stealconfig.js can/util/util is being mapped to can/util/jquery/jquery. This fixes it by putting the mapping back to can/util/util directly in the stealify options.
Map is used for the `esc` function.
The steal plugins will use steal syntax because the ES6 system is dependent on Traceur which doesn't work in IE8 or Phantom 1.x. Once Phantom 2 is released we can probably start using ES6 syntax.
…ystem-steal-domless
This updates the builder.json file to work with a new "loader" type that includes can/util/domless and can/view/stache/system.
Instead of module directly. This is necessary because in the new Steal module is reserved and not available.
This updates everything needed so that jquery's pluginified test all pass. The biggest obstacle was that there isn't a central place to get all of the tests, so I created test/all-tests.js that contain all of the tests. The old pluginify builder had a way of combining modules that need to be pluginified into one; the new pluginify doesn't have that. You must specify a `main` module, which is why all-tests.js was created.
Store docs
This includes the beginnings of some dojo hacks to get it to run inside SystemJS.
This is used by bitovi-tools and doesn't need to be in CanJS.
CommonJS build, auto-render and can-import
All tests passing in IE8+ and evergreen browsers.
…is called to allow devs to change scope in destroy
Adding warning if a tag is being redefined
Moved jquery out of travis.yml file and into devDependencies #1418
Unbind component bindings after destroy is called
…tthewp-issue-887 # Conflicts: # view/bindings/bindings_test.js
See conversation here: #888 (comment)
|
This needs to be submitted against the minor branch. You can change the target branch when creating the PR so we'll probably have to close this one and submit it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged and resolved conflict from Matthew's original PR #888. And updated setter based on Justin's reco here: #888 (diff)
Matthew's PR fixes issue #887: can-value becomes out of sync when a compute rejects the new value #887