Mustache dev logging #919
Closed
Mustache dev logging #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! For this to close those issues, we will need similar warnings in can.stache. If you are interested, the similar place this happens in stache is here: https://github.com/bitovi/canjs/blob/minor/view/stache/mustache_core.js#L215 |
|
I think "in mustache template" in:
is imprecise. Perhaps |
|
Yep you are right. I'll update that. |
Merged
|
Closing this as it should be going to master. New PR is #927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some better dev logging for mustache templates. I'm not sure of some of the intricacies of how it resolves when deeply nested, so I'm not sure if I'm missing any cases here but this should close #720 and #726.